Re: Add comments about fire_triggers argument in ri_triggers.c

From: surya poondla <suryapoondla4(at)gmail(dot)com>
To: Yugo Nagata <nagata(at)sraoss(dot)co(dot)jp>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: Add comments about fire_triggers argument in ri_triggers.c
Date: 2026-01-29 00:56:19
Message-ID: CAOVWO5q8cfbHiZuL-wSxknnriPCBYpqRCnQKfH38WuLwFuxkSw@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi Yugo,

Your patch change looks good.

Yes Amit, I agree that SPI_execute_snapshot() comments do provide some
context on AFTER triggers, but I still feel the newly added comment
in ri_PerformCheck() gives additional context on why the fire_triggers is
set to false.

Regards,
Surya Poondla

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Heikki Linnakangas 2026-01-29 01:05:33 Re: Interrupts vs signals
Previous Message Michael Paquier 2026-01-29 00:32:14 Re: psql: make %P prompt option consistent when not connected