| From: | surya poondla <suryapoondla4(at)gmail(dot)com> |
|---|---|
| To: | Peter Smith <smithpb2250(at)gmail(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "zhong950419(at)gmail(dot)com" <zhong950419(at)gmail(dot)com>, shveta malik <shveta(dot)malik(at)gmail(dot)com> |
| Subject: | Re: Missing list_free in publicationcmds.c:OpenTableList |
| Date: | 2026-08-10 22:20:20 |
| Message-ID: | CAOVWO5q8+MBoLDq1u4BfufKtiYnHS48cJNJ5PaNm9m_aZb90tA@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi Peter,
+1 for v2, I confirmed the premise: OpenTableList() is only reached from
CreatePublication() and AlterPublicationTables(), i.e. once
per DDL statement, with the lists allocated in the command's context.
Can you add a comment before the return something like
/*
* relids, relids_with_rf and relids_with_collist are deliberately
not
* freed here. This function runs at most once per DDL command, the
* surrounding command-lifetime memory context frees them later.
*/
So future readers will not think of it as a bug.
This is only a suggestion, feel free to skip it if you'd rather keep the
patch minimal.
Regards,
Surya Poondla
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Smith | 2026-08-10 22:22:18 | Re: Improve errmsg for publication membership |
| Previous Message | Chao Li | 2026-08-10 21:50:27 | Re: pg_control_checkpoint(): add "data_checksum_version" (Pg19)? |