Re: Missing list_free in publicationcmds.c:OpenTableList

From: surya poondla <suryapoondla4(at)gmail(dot)com>
To: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
Cc: Peter Smith <smithpb2250(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "zhong950419(at)gmail(dot)com" <zhong950419(at)gmail(dot)com>, shveta malik <shveta(dot)malik(at)gmail(dot)com>
Subject: Re: Missing list_free in publicationcmds.c:OpenTableList
Date: 2026-08-11 04:40:23
Message-ID: CAOVWO5orvdoUmOtonB_3cC6DCo3BBDi0CQD=jgxA4DOv8Tj2Sw@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi Amit,

Yes, I have a similar understanding so let's not set a precedent that
> could invite similar comments sprinkled everywhere a list_free/pfree
> is not called, which is noise rather than signal.
>

Sounds good, v2 looks good to me.
My only thought was that the next reader might report it as a leak
again but I agree the comment isn't necessary.

Regards,
Surya Poondla

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Chao Li 2026-08-11 04:55:18 Re: preventing shell injection
Previous Message 贾明伟 2026-08-11 04:33:29 [RFC PATCH v3 0/7] Umbra: a remap-aware smgr prototype