| From: | tomohiro hiramitsu <hiramit(dot)tm(at)gmail(dot)com> |
|---|---|
| To: | Kasahara Tatsuhito <kasahara(dot)tatsuhito(at)gmail(dot)com> |
| Cc: | Magnus Hagander <magnus(at)hagander(dot)net>, Andres Freund <andres(at)anarazel(dot)de>, Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>, skoposov(at)ed(dot)ac(dot)uk, PostgreSQL mailing lists <pgsql-bugs(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: BUG #16722: PG hanging on COPY when table has close to 2^32 toasts in the table. |
| Date: | 2021-03-01 01:56:50 |
| Message-ID: | CAOR2cEb4Suwnk+rvC-Ea1BmOKXTg-nV--N9f+rRo4TEZztN7bg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
Hi,
On Wed, Jan 6, 2021 at 11:13 AM Kasahara Tatsuhito
<kasahara(dot)tatsuhito(at)gmail(dot)com> wrote:
> Here are some comments about the code.
>
> +#define GETNEWOID_NOTIFICATION_INTERVAL_FACTOR 1000000
>
> It seems to be more of a minimum value for conflict detection rather
> than an interval factor.
> So, it would be better to use another name, such as
> GETNEWOID_NOTIFICATION_MINVAL or others.
>
> + /* retry count and notification limit check */
> + if (retry_count == next_notify && next_notify <=
> GETNEWOID_NOTIFICATION_LIMIT)
> + {
> + ereport(LOG,
> + (errmsg("failed to assign new OID in relation \"%s\"
> after "UINT64_FORMAT" retries",
> + RelationGetRelationName(relation), retry_count)));
> + next_notify *= 2; /* double it for the next notification */
> + }
> + retry_count++;
>
> I think that we should add more comments about why output this LOG
message.
Thank you for your comment.
I reflected your comment in the patch.
* v2-0001-GetNewOidWithIndex_log_output.patch
Best regards,
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0001-GetNewOidWithIndex_log_output.patch | application/octet-stream | 2.5 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Kyotaro Horiguchi | 2021-03-01 02:24:52 | Re: BUG #16722: PG hanging on COPY when table has close to 2^32 toasts in the table. |
| Previous Message | Tom Lane | 2021-03-01 01:34:55 | Re: Bug : Did't show Constaint violation error |