Re: BUG #16722: PG hanging on COPY when table has close to 2^32 toasts in the table.

From: tomohiro hiramitsu <hiramit(dot)tm(at)gmail(dot)com>
To: Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, Kasahara Tatsuhito <kasahara(dot)tatsuhito(at)gmail(dot)com>, Magnus Hagander <magnus(at)hagander(dot)net>, Andres Freund <andres(at)anarazel(dot)de>, skoposov(at)ed(dot)ac(dot)uk, PostgreSQL mailing lists <pgsql-bugs(at)lists(dot)postgresql(dot)org>
Subject: Re: BUG #16722: PG hanging on COPY when table has close to 2^32 toasts in the table.
Date: 2021-03-22 09:19:33
Message-ID: CAOR2cEZUBHgB5tyo+u9XpqFiJKYOz_5y4vC68tX0p7yR9YqwCA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

On Fri, Mar 19, 2021 at 1:32 AM Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>
wrote:
> WARNING is more suitable for these kinds of messages?
> I changed the log level here to WARNING.
>
> +#define GETNEWOID_NOTIFY_MINVAL 1000000
> +#define GETNEWOID_NOTIFY_MAXVAL 100000000
>
> If we use WARNING, GETNEWOID_WARN_THRESHOLD and
GETNEWOID_WARN_MAX_INTERVAL
> sound better to me for the meanings of them. I renamed them.

When "LOG" is set, SQL statements can be recorded in the server log even if
log_min_error_statement is set to "ERROR"(default).
It would be useful for users to know which SQL statement is retrying to
generate OIDs.

In this case, GETNEWOID_WARN_THRESHOLD and GETNEWOID_WARN_MAX_INTERVAL
should be renamed to the following names.

* GETNEWOID_LOG_THRESHOLD
* GETNEWOID_LOG_MAX_INTERVAL

Best regards,
--
Tomohiro Hiramitsu
NTT Open Source Software Center

>

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Fujii Masao 2021-03-22 10:53:56 Re: BUG #16722: PG hanging on COPY when table has close to 2^32 toasts in the table.
Previous Message Michael Paquier 2021-03-22 06:21:20 Re: BUG #16854: initdb fails on ReFS and FAT32 file systems