| From: | Kohei KaiGai <kaigai(at)heterodb(dot)com> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: add_partial_path() may remove dominated path but still in use |
| Date: | 2019-01-11 02:09:59 |
| Message-ID: | CAOP8fzZN9JwT466Lp-WYv9wGHZoPfG_qS2_fJ0wxiVKxitZwkw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
2019年1月11日(金) 5:52 Robert Haas <robertmhaas(at)gmail(dot)com>:
>
> On Wed, Jan 9, 2019 at 12:44 AM Kohei KaiGai <kaigai(at)heterodb(dot)com> wrote:
> > So, is it sufficient if set_rel_pathlist_hook is just relocated in
> > front of the generate_gather_paths?
> > If we have no use case for the second hook, here is little necessity
> > to have the post_rel_pathlist_hook() here.
> > (At least, PG-Strom will use the first hook only.)
>
> +1. That seems like the best way to be consistent with the principle
> that we need to have all the partial paths before generating any
> Gather paths.
>
Patch was updated, just for relocation of the set_rel_pathlist_hook.
Please check it.
Thanks,
--
HeteroDB, Inc / The PG-Strom Project
KaiGai Kohei <kaigai(at)heterodb(dot)com>
| Attachment | Content-Type | Size |
|---|---|---|
| pgsql-bugfix-relocation-path-set_rel_pathlist_hook.v10.patch | application/octet-stream | 1.5 KB |
| pgsql-bugfix-relocation-path-set_rel_pathlist_hook.v11.patch | application/octet-stream | 1.4 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Etsuro Fujita | 2019-01-11 02:21:01 | Re: Query with high planning time at version 11.1 compared versions 10.5 and 11.0 |
| Previous Message | Amit Langote | 2019-01-11 02:07:58 | Re: speeding up planning with partitions |