|From:||Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp>|
|To:||David Rowley <david(dot)rowley(at)2ndquadrant(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>|
|Cc:||Amit Langote <amitlangote09(at)gmail(dot)com>, "Imai, Yoshikazu" <imai(dot)yoshikazu(at)jp(dot)fujitsu(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>|
|Subject:||Re: speeding up planning with partitions|
|Views:||Raw Message | Whole Thread | Download mbox | Resend email|
Sorry, I hadn't read this email before sending my earlier "thank you for
On 2019/01/11 6:47, David Rowley wrote:
> On Fri, 11 Jan 2019 at 06:56, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> wrote:
>> Pushed 0001 with some minor tweaks, thanks.
> Thanks for pushing. I had looked at 0001 last night and there wasn't
> much to report, just:
> v12 0001
> 1. I see you've moved translate_col_privs() out of prepunion.c into
> appendinfo.c. This required making it an external function, but it's
> only use is in inherit.c, so would it not be better to put it there
> and keep it static?
Actually, I *was* a bit puzzled where to put it. I tend to agree with you
now that it might be define it locally within inherit.c as it might not be
needed elsewhere. Let's hear what Alvaro thinks. I'm attaching a patch
> 2. The following two lines I think need to swap their order.
> +#include "utils/rel.h"
> +#include "utils/lsyscache.h"
> Both are pretty minor details but thought I'd post them anyway.
Thank you for reporting.
Attached find the patch.
|Next Message||Kohei KaiGai||2019-01-11 02:09:59||Re: add_partial_path() may remove dominated path but still in use|
|Previous Message||David Fetter||2019-01-11 02:06:59||Re: Commitfest delayed: extend it?|