Re: doc: REPACK is missing from the MAINTAIN privilege documentation

On Wed, Jul 15, 2026 at 12:02 PM Shinya Kato <shinya11(dot)kato(at)gmail(dot)com> wrote:
>
> Hi hackers,
>
> REPACK requires the MAINTAIN privilege, as its documentation states,
> but REPACK is missing from the two places that enumerate the commands
> MAINTAIN covers: the MAINTAIN privilege description in ddl.sgml and
> the pg_maintain predefined role description in user-manag.sgml. This
> looks like an oversight in commit ac58465e061, which introduced
> REPACK.
>
> The attached patch adds REPACK next to CLUSTER in both places.

Confirmed, and the patch looks correct to me. REPACK does require
MAINTAIN (per repack.sgml), and ac58465e061 missed adding it to these
lists.

I went through the other places that mention MAINTAIN, and these two are
indeed the only spots that enumerate the covered commands: grant.sgml
just points at ddl-priv, the privilege-abbreviations table only gives
the name/letter, and the GRANT/REVOKE synopses list MAINTAIN as a
keyword rather than expanding it. The per-command reference pages only
state that they require MAINTAIN. So the patch is complete. The
sql-repack link target exists too, and putting REPACK right after
CLUSTER reads well.

+1 from me.

>
> Thoughts?
>
> --
> Best regards,
> Shinya Kato
> NTT OSS Center

--
Regards,
Ewan Young