| From: | Ewan Young <kdbase(dot)hack(at)gmail(dot)com> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Tender Wang <tndrwang(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: satisfies_hash_partition crash |
| Date: | 2026-07-03 02:07:46 |
| Message-ID: | CAON2xHM8JEUxW-Qp9VJt9yb2Nj_N-xyrG4mHLu0+Ffg1xJcS6A@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Jul 3, 2026 at 1:54 AM Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
>
> On Thu, Jul 2, 2026 at 2:17 AM Tender Wang <tndrwang(at)gmail(dot)com> wrote:
> > Personally, I prefer a local bool variable near the top and reuse it.
>
> I prefer to more thoroughly confine this fix to the variadic code
> path, since I don't think we really expect that to be exercised in
> practice. So here's my proposal.
v2 looks good to me — I tested it and confirmed that it works. Thanks
for picking this up.
>
> --
> Robert Haas
> EDB: http://www.enterprisedb.com
--
Regards,
Ewan Young
| From | Date | Subject | |
|---|---|---|---|
| Next Message | feng wu | 2026-07-03 02:08:40 | Re: [PATCH] Avoid internal error for invalid interval typmods |
| Previous Message | Japin Li | 2026-07-03 01:57:46 | Terminology: "temporary relation" vs "temporary table" in tablecmds.c |