Re: Avoid corrupting DefElem nodes when parsing publication_names and publish options

From: sunil s <sunilfeb26(at)gmail(dot)com>
To: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Avoid corrupting DefElem nodes when parsing publication_names and publish options
Date: 2025-12-24 11:42:36
Message-ID: CAOG6S49=+qSmuw9h3spqUP8g_6MYJ=-4BUyjUTUSK_8JJyz8ZQ@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Here is the reproduction of this issue.

As per the official documentation
<https://www.postgresql.org/docs/current/sql-createpublication.html>, creating
a publication with the following syntax will corrupt the option
list('insert, update, delete')

> CREATE PUBLICATION mypublication FOR ALL TABLES WITH (publish ='insert,
update, delete');

By attaching a debugger to *parse_publication_options(), *we can verify
that the option list is modified after the call to
*splitIdentifierString().*

NOTE: Using double quotes (" "), the functionality works correctly.

Thanks & Regards,
Sunil S

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Jeevan Chalke 2025-12-24 11:44:18 Add --extra-dependencies and immediate data dumping for pg_dump/pg_upgrade
Previous Message sunil s 2025-12-24 11:25:12 Avoid corrupting DefElem nodes when parsing publication_names and publish options