| From: | Enrique Sánchez <enriqueesanchz(at)gmail(dot)com> |
|---|---|
| To: | Ilia Evdokimov <ilya(dot)evdokimov(at)tantorlabs(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Extended statistics improvement: multi-column MCV missing values |
| Date: | 2026-07-28 23:26:21 |
| Message-ID: | CAOCkzAkE=tgZsH71YRLF-dPsAR8Mjyr3QWYsMAjsVXGxZxZ1eg@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi Ilia, thanks for the review!
I've fixed the cosmetic nits in v7 and attached it to the next email.
Best regards,
Enrique.
On, 24 Jul 2026 at 17:03, Ilia Evdokimov (<ilya(dot)evdokimov(at)tantorlabs(dot)com>)
wrote:
> The overall approach looks architecturally correctly. Just two cosmetic
> nits:
>
> 1. In `mcv_can_cap()`, the early-exit branch uses braces around `return
> false`. This would normally be written without braces.
>
> 2. The doc comment above `mcv_can_cap()` says condition requires the
> clause to be either an equality operator, or a bare boolean Var, but
> implementation actually handles one more cases - `NOT var`
>
> 3. Apply pgindent into diff.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Enrique Sánchez | 2026-07-28 23:38:53 | Re: Extended statistics improvement: multi-column MCV missing values |
| Previous Message | Peter Smith | 2026-07-28 23:14:36 | Re: PSQL schema "describe" \dn is not escaping quotes |