From: | Julien Rouhaud <rjuju123(at)gmail(dot)com> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | David Rowley <david(dot)rowley(at)2ndquadrant(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Ash M <makmarath(at)hotmail(dot)com>, PostgreSQL mailing lists <pgsql-bugs(at)lists(dot)postgresql(dot)org> |
Subject: | Re: BUG #15572: Misleading message reported by "Drop function operation" on DB with functions having same name |
Date: | 2019-02-19 16:00:26 |
Message-ID: | CAOBaU_bPFBb=BA8Askv+1yvcrCFE0-zk3R8XwgbHTY4bhfy1fg@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-bugs pgsql-hackers |
On Sun, Feb 17, 2019 at 11:31 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>
> David Rowley <david(dot)rowley(at)2ndquadrant(dot)com> writes:
> > On Tue, 12 Feb 2019 at 16:09, Michael Paquier <michael(at)paquier(dot)xyz> wrote:
> >> FWIW, it makes me a bit uneasy to change this function signature in
> >> back-branches if that's the intention as I suspect that it gets used
> >> in extensions.. For HEAD that's fine of course.
>
> > I wondered about this too and questioned Tom about it above. There
> > was no response.
>
> Sorry, I didn't realize you'd asked a question.
>
> > I just assumed Tom didn't think it was worth fiddling with in back-branches.
>
> Yeah, exactly. Not only do I not feel a need to change this behavior
> in the back branches, but the original patch is *also* an API change,
> in that it changes the behavior of what appears to be a well-defined
> boolean parameter. The fact that none of the call sites found in
> core today would care doesn't change that; you'd still be risking
> breaking extensions, and/or future back-patches.
Extensions calling those functions with old true/false values probably
won't get any warning or error during compile. Is is something we
should worry about or is it enough to keep the same behavior in this
case?
@david: small typo, you removed a space in this chunk
- * LookupFuncName and let it make any error messages. Otherwise, we make
+ * LookupFuncNameand let it make any error messages. Otherwise, we make
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2019-02-19 16:45:59 | Re: BUG #15572: Misleading message reported by "Drop function operation" on DB with functions having same name |
Previous Message | Jeremy Finzel | 2019-02-19 15:32:15 | Re: Segmentation Fault in logical decoding get/peek API |
From | Date | Subject | |
---|---|---|---|
Next Message | Peter Eisentraut | 2019-02-19 16:07:25 | Re: FOP warnings about id attributes in title tags |
Previous Message | Magnus Hagander | 2019-02-19 15:59:35 | Re: Some thoughts on NFS |