Re: installcheck fails when compute_query_id=on or pg_stat_statsement is loaded

On Fri, Oct 15, 2021 at 3:36 PM Мельников Антон Андреевич
<aamelnikov(at)inbox(dot)ru> wrote:
>
> When extension pg_stat_statsement is loaded into memory or compute_query_id=on in postgesql.conf
> many of installcheck tests give errors.
> [...]
> I think this is a problem because these fake errors can mask a real errors in relevant tests.
> What’s your opinion?

This has been discussed previously (although I can't find the thread
right now). Note that you don't really need to enable
pg_stat_statements, enabling compute_query_id is enough. The query
identifier is only displayed for EXPLAIN (VERBOSE), so it's already a
bit filtered. I don't see any simple way to entirely avoid the
problem though.

There are already many options that can break the regression tests, so
maybe it's ok to accept that this is yet another one. If not, the
only alternative I see is to add a boolean QUERY_ID option to EXPLAIN
and make sure that all tests use it, but it seems like a big hammer,
error prone, for a maybe small problem.