| From: | Julien Rouhaud <rjuju123(at)gmail(dot)com> |
|---|---|
| To: | vignesh C <vignesh21(at)gmail(dot)com> |
| Cc: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Enhanced error message to include hint messages for redundant options error |
| Date: | 2021-05-02 11:42:54 |
| Message-ID: | CAOBaU_ajsYtFLOWevn5LJ+-sv=xerh07nRSa2momJKqi6ao5Aw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Le dim. 2 mai 2021 à 18:31, vignesh C <vignesh21(at)gmail(dot)com> a écrit :
> On Sun, May 2, 2021 at 4:27 AM Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
> wrote:
> >
> > On 2021-May-01, Bharath Rupireddy wrote:
> >
> > > IMO, it's not good to change the function API just for showing up
> > > parse_position (which is there for cosmetic reasons I feel) in an error
> > > which actually has the option name clearly mentioned in the error
> message.
> >
> > Why not? We've done it before, I'm sure you can find examples in the
> > git log. The function API is not that critical -- these functions are
> > mostly only called from ProcessUtility and friends.
>
> I feel it is better to include it wherever possible.
>
+1
>
| From | Date | Subject | |
|---|---|---|---|
| Next Message | vignesh C | 2021-05-02 15:12:30 | Re: Enhanced error message to include hint messages for redundant options error |
| Previous Message | vignesh C | 2021-05-02 10:30:59 | Re: Enhanced error message to include hint messages for redundant options error |