| From: | Julien Rouhaud <rjuju123(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, Noah Misch <noah(at)leadboat(dot)com>, Jaime Casanova <jcasanov(at)systemguards(dot)com(dot)ec>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: SQL-standard function body |
| Date: | 2021-06-07 15:56:46 |
| Message-ID: | CAOBaU_ajK_0=jWW=v0LvY8+_H5cXDAWtPYyBHnb6RRKA821ZRQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Jun 7, 2021 at 11:27 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>
> Julien Rouhaud <rjuju123(at)gmail(dot)com> writes:
> > On Mon, Jun 7, 2021 at 4:52 PM Peter Eisentraut
> > <peter(dot)eisentraut(at)enterprisedb(dot)com> wrote:
> >> Your patch filters out empty statements at the parse transformation
> >> phase, so they are no longer present when you dump the body back out.
> >> So your edits in the test expected files don't fit.
>
> > Oh, somehow the tests aren't failing here, I'm not sure what I did wrong.
>
> Modulo getting the tests right ...
I can certainly accept that my patch broke the tests, but I just ran
another make check-world and it passed without any problem. What am I
missing?
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bossart, Nathan | 2021-06-07 16:02:03 | Re: please update ps display for recovery checkpoint |
| Previous Message | Robert Haas | 2021-06-07 15:37:58 | Re: libpq debug log |