| From: | Julien Rouhaud <rjuju123(at)gmail(dot)com> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Daniel Verite <daniel(at)manitou-mail(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Kevin Grittner <kgrittn(at)gmail(dot)com> |
| Subject: | Re: Add parallelism and glibc dependent only options to reindexdb |
| Date: | 2019-07-22 15:23:30 |
| Message-ID: | CAOBaU_aVMhCse3H5sONuB7uFCN8ZkT7h9mzoONF2bhcsNUFsyA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Jul 22, 2019 at 5:11 PM Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> wrote:
>
> On 2019-Jul-22, Julien Rouhaud wrote:
>
> > On Mon, Jul 22, 2019 at 6:11 AM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>
> > > simple_string_list_append(&tables, optarg);
> > > + tbl_count++;
> > > break;
> > > The number of items in a simple list is not counted, and vacuumdb does
> > > the same thing to count objects. What do you think about extending
> > > simple lists to track the number of items stored?
> >
> > I considered this, but it would require to adapt all code that declare
> > SimpleStringList stack variable (vacuumdb.c, clusterdb.c,
> > createuser.c, pg_dumpall.c and pg_dump.c), so it looked like too much
> > trouble to avoid 2 local variables here and 1 in vacuumdb.c. I don't
> > have a strong opinion here, so I can go for it if you prefer.
>
> Can we use List for this instead?
Isn't that for backend code only?
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2019-07-22 15:33:01 | Re: Add parallelism and glibc dependent only options to reindexdb |
| Previous Message | Alvaro Herrera | 2019-07-22 15:18:06 | Re: Add parallelism and glibc dependent only options to reindexdb |