| From: | Julien Rouhaud <rjuju123(at)gmail(dot)com> |
|---|---|
| To: | Magnus Hagander <magnus(at)hagander(dot)net> |
| Cc: | Robert Treat <rob(at)xzilla(dot)net>, Julien Rouhaud <rjuju123(at)gmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, David Steele <david(at)pgmasters(dot)net>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Checksum errors in pg_stat_database |
| Date: | 2019-04-17 13:07:04 |
| Message-ID: | CAOBaU_aK7pY2nJZgFjhkuZmAvEVR6Z_H3My6BUUfwgSfrbeLQQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Apr 17, 2019 at 1:55 PM Magnus Hagander <magnus(at)hagander(dot)net> wrote:
>
> On Tue, Apr 16, 2019 at 5:39 PM Robert Treat <rob(at)xzilla(dot)net> wrote:
>>
>> On Mon, Apr 15, 2019 at 3:32 PM Julien Rouhaud <rjuju123(at)gmail(dot)com> wrote:
>> >
>> > I don't know if that counts as an open item, but I attach a patch for
>> > all points discussed here.
>>
>> ISTM we should mention shared objects in both places in the docs, and
>> want "NULL if data checksums" rather than "NULL is data checksums".
>> Attaching slightly modified patch with those changes, but otherwise
>> LGTM.
Thanks, that's indeed embarassing typos. And agreed for mentioning
shared objects in both places.
>
> Interestingly enough, that patch comes out as corrupt. I have no idea why though :) v1 is fine.
>
> So I tried merging back your changes into it, and then pushing. Please doublecheck I didn't miss something :)
Thanks! I double checked and it all looks fine.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2019-04-17 13:11:20 | Re: log_planner_stats and prepared statements |
| Previous Message | Etsuro Fujita | 2019-04-17 12:49:24 | Re: bug in update tuple routing with foreign partitions |