Re: pg13 PGDLLIMPORT list

From: Julien Rouhaud <rjuju123(at)gmail(dot)com>
To: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
Cc: Michael Paquier <michael(at)paquier(dot)xyz>, legrand legrand <legrand_legrand(at)hotmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pg13 PGDLLIMPORT list
Date: 2020-01-18 07:19:19
Message-ID: CAOBaU_a2DCoPX-7e2rsnpKSUhy+cq191zUoGck=W2-KdSdMK-A@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sat, 18 Jan 2020, 09:04 Amit Kapila <amit(dot)kapila16(at)gmail(dot)com wrote:

> On Sat, Jan 18, 2020 at 7:56 AM Michael Paquier <michael(at)paquier(dot)xyz>
> wrote:
> >
> > On Fri, Jan 17, 2020 at 03:07:48PM -0700, legrand legrand wrote:
> > > Would it be possible to add PGDLLIMPORT to permit to build following
> > > extensions on windows
> > >
> > > pg_stat_sql_plans:
> > > src/include/pgstat.h
> > > extern PGDLLIMPORT bool pgstat_track_activities;
> > >
> > > pg_background:
> > > src/include/storage/proc.h
> > > extern PGDLLIMPORT int StatementTimeout;
> >
> > No objections from me to add both to what's imported.
> >
>
> +1 for adding PGDLLIMPORT to these variables. In the past, we have
> added it on the request of some extension authors, so I don't see any
> problem doing this time as well.
>

+1 too

>

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Lætitia Avrot 2020-01-18 08:11:07 Re: [Doc] pg_restore documentation didn't explain how to use connection string
Previous Message Amit Kapila 2020-01-18 07:04:14 Re: pg13 PGDLLIMPORT list