From: | Julien Rouhaud <rjuju123(at)gmail(dot)com> |
---|---|
To: | Martijn van Oosterhout <kleptog(at)gmail(dot)com> |
Cc: | Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: IDEA: pg_stat_statements tracking utility statements by tag? |
Date: | 2020-07-29 16:35:41 |
Message-ID: | CAOBaU_Zv_xX0E7GDDuDoOakgjvc9YKxjN8OwpJ2mD=jqaqcpug@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Wed, Jul 29, 2020 at 5:29 PM Martijn van Oosterhout
<kleptog(at)gmail(dot)com> wrote:
>
>
> On Wed, 29 Jul 2020 at 15:40, Julien Rouhaud <rjuju123(at)gmail(dot)com> wrote:
>>
>> On Wed, Jul 29, 2020 at 2:42 PM Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com> wrote:
>> >
>> >
>> > Or, we should extend the existing query normalization to handle also DDL?
>>
>> +1, introducing DDL normalization seems like a better way to go in the
>> long run. Defining what should and shouldn't be normalized can be
>> tricky though.
>
>
> In principle, the only thing that really needs to be normalised is SAVEPOINT/CURSOR names which are essentially random strings which have no effect on the result. Most other stuff is material to the query.
>
> That said, I think "aggregate by tag" has value all by itself. Being able to collapse all CREATE TABLES into a single line can be useful in some situations.
There's at least PREPARE TRANSACTION / COMMIT PREPARED / ROLLBACK
PREPARED that should be normalized too. I also don't think that we
really want to have different entries for begin / Begin / BEGIN /
bEgin and similar for many other commands, as the hash is computed
based on the query text.
From | Date | Subject | |
---|---|---|---|
Next Message | Jeff Davis | 2020-07-29 17:07:51 | HyperLogLog.c and pg_leftmost_one_pos32() |
Previous Message | Robert Haas | 2020-07-29 16:09:49 | Re: [Patch] ALTER SYSTEM READ ONLY |