Re: Add function to return backup_label and tablespace_map

From: Julien Rouhaud <rjuju123(at)gmail(dot)com>
To: David Steele <david(at)pgmasters(dot)net>
Cc: Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Nathan Bossart <nathandbossart(at)gmail(dot)com>, Stephen Frost <sfrost(at)snowman(dot)net>
Subject: Re: Add function to return backup_label and tablespace_map
Date: 2022-07-08 12:22:50
Message-ID: CAOBaU_Ztdn+bsB_OSx42HW_sDNxP4_2nCq0FU0Vb8ZJpN=dsvw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Jul 8, 2022 at 7:42 PM David Steele <david(at)pgmasters(dot)net> wrote:
>
> On 7/7/22 12:43, Fujii Masao wrote:
>
> > Since an exclusive backup method was dropped in v15, in v15 or later, we
> > need to create backup_label and tablespace_map files from the result of
> > pg_backup_stop() when taking a base backup using low level backup API.
> > One issue when doing this is that; there is no simple way to create
> > those files from two columns "labelfile" and "spcmapfile" that
> > pg_backup_stop() returns if we execute it via psql. Probaby we need to
> > store those columns in a temporary file and run some OS commands or
> > script to separate that file into backup_label and tablespace_map.
>
> Why not just select these columns into a temp table:
>
> create temp table backup_result as select * from pg_backup_stop(...);
>
> Then they can be easily dumped with \o by selecting from the temp table.

That wouldn't help people making backups from standby servers.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Bharath Rupireddy 2022-07-08 12:24:13 Re: Patch proposal: New hooks in the connection path
Previous Message David Steele 2022-07-08 12:20:09 Re: remove more archiving overhead