| From: | Julien Rouhaud <rjuju123(at)gmail(dot)com> |
|---|---|
| To: | Magnus Hagander <magnus(at)hagander(dot)net> |
| Cc: | David Steele <david(at)pgmasters(dot)net>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Checksum errors in pg_stat_database |
| Date: | 2019-03-09 18:53:41 |
| Message-ID: | CAOBaU_ZdoLQ-ULYk8canO3CaygbHCHd1MpcTvh_Vm4OKKi1Gsg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sat, Mar 9, 2019 at 7:48 PM Magnus Hagander <magnus(at)hagander(dot)net> wrote:
>
> On Sat, Mar 9, 2019 at 12:33 AM Julien Rouhaud <rjuju123(at)gmail(dot)com> wrote:
>>
>> Thanks! Our implementations are quite similar, so I'm fine with most
>> of the changes :) I'm just not sure about having two distinct
>> functions for reporting failures, given that there's only one caller
>> for each. On the other hand it avoids to include miscadmin.h in
>> bufpage.c.
>
>
> Yeah, and it brings "cosistence" to at least the calling point(s) within regular backends.
>
>
>>
>> That's just a detail, so I'm marking it (again) as ready for committer!
>
>
> Thanks, and pushed :)
Thanks :)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Julien Rouhaud | 2019-03-09 18:58:19 | Re: Checksum errors in pg_stat_database |
| Previous Message | Magnus Hagander | 2019-03-09 18:49:50 | Re: Checksum errors in pg_stat_database |