| From: | Julien Rouhaud <rjuju123(at)gmail(dot)com> |
|---|---|
| To: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
| Cc: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, Robert Haas <robertmhaas(at)gmail(dot)com>, Laurenz Albe <laurenz(dot)albe(at)cybertec(dot)at>, Douglas Doole <dougdoole(at)gmail(dot)com>, Christoph Berg <myon(at)debian(dot)org>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Collation versioning |
| Date: | 2020-11-02 13:08:26 |
| Message-ID: | CAOBaU_ZYyxQ3sJR932NFs5HHh++RqXDGwe1S5ubBv8nmsHXCog@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Nov 2, 2020 at 9:04 PM Thomas Munro <thomas(dot)munro(at)gmail(dot)com> wrote:
>
> On Mon, Nov 2, 2020 at 10:28 PM Julien Rouhaud <rjuju123(at)gmail(dot)com> wrote:
> > + /* Remember not to complain about this collation again. */
> > + context->checked_colls = lappend_oid(context->checked_colls,
> > + otherObject->objectId);
> >
> > It's maybe not immediately obvious that it's safe to save the
> > collation oid at that point, or that it'll always be. Maybe move it
> > in the if branch above to make it extra clear?
>
> Ok, moved and renamed, and finally pushed. Thanks for all the help!
\o/ Thanks a lot Thomas!
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Magnus Hagander | 2020-11-02 13:18:32 | Re: pg_upgrade analyze script |
| Previous Message | Thomas Munro | 2020-11-02 13:03:34 | Re: Collation versioning |