Re: Lexer issues

From: Julien Rouhaud <rjuju123(at)gmail(dot)com>
To: Patrick REED <patrickreed352(at)gmail(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Lexer issues
Date: 2020-04-14 09:00:21
Message-ID: CAOBaU_ZO0YkU5Aj7gQVLy8mNpijEWkyO3SP4Tn2Hg4Yn8bGzHg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hello,

On Mon, Apr 13, 2020 at 4:04 PM Patrick REED <patrickreed352(at)gmail(dot)com> wrote:
>
> I am experimenting with postgres and am wondering if there is any tutorial on how to properly add a new command to postgres.
>
> I want to add a new constraint on "CREATE ROLE" that requires an integer, it has an identifier that is not a known (reserved or unreserved keyword) in postgres, say we call it TestPatrick. In other words, I want to do this "CREATE ROLE X TestPatrick=10". I am having an issue with having postgres recognize my new syntax.
>
> I have seen this video: https://www.youtube.com/watch?v=uSEXTcEiXGQ and was able to add have my postgres compile with my added word (modified gram.y, kwlist.h, gram.cpp etc based on the video). However, when I use my syntax on a client session, it still doesn't recognize my syntax... Are there any specific lexer changes I need to make? I followed the example of CONNECTION LIMIT and tried to mimic it for Create ROLE.

I'd think that if you can get a successful compilation with a modified
gram.y (and any kwlist change needed) the new syntax should be
accepted (at least up to the parser, whether the utility command is
properly handled is another thing), since there's a single version of
the CreateRoleStmt. Is there any chance that you're somehow
connecting to something else than the freshly make-install-ed binary,
or that the error is coming from later stage than parsing?

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message David Rowley 2020-04-14 09:09:31 Re: [PATCH] Keeps tracking the uniqueness with UniqueKey
Previous Message Amit Langote 2020-04-14 08:58:36 Re: index paths and enable_indexscan