| From: | Julien Rouhaud <rjuju123(at)gmail(dot)com> |
|---|---|
| To: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Cc: | Jehan Guillaume De Rorthais ioguix <ioguix(at)free(dot)fr> |
| Subject: | Non working timeout detection in logical worker |
| Date: | 2019-10-17 18:00:15 |
| Message-ID: | CAOBaU_ZHESFcWva8jLjtZdCLspMj7vqaB2k++rjHLY897ZxbYw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hello,
Jehan-Guillaume (in Cc) reported me today a problem with logical
replication, where in case of network issue the walsender is correctly
terminating at the given wal_sender_timeout but the logical worker
kept waiting indefinitely.
The issue is apparently a simple thinko, the timestamp of the last
received activity being unconditionally set at the beginning of the
main processing loop, making any reasonable timeout setting
ineffective. Trivial patch to fix the problem attached.
| Attachment | Content-Type | Size |
|---|---|---|
| fix_logical_worker_timeout-v1.diff | application/octet-stream | 796 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Lars Kanis | 2019-10-17 18:04:19 | libpq: Fix wrong connection status on invalid "connect_timeout" |
| Previous Message | Jeremy Finzel | 2019-10-17 17:49:38 | UPSERT on view does not find constraint by name |