Re: Planning counters in pg_stat_statements (using pgss_store)

From: Julien Rouhaud <rjuju123(at)gmail(dot)com>
To: legrand legrand <legrand_legrand(at)hotmail(dot)com>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Planning counters in pg_stat_statements (using pgss_store)
Date: 2020-01-21 10:21:20
Message-ID: CAOBaU_YoVqLTV4FpQ=jt3jT8BHv1nYMxes3i1wWtS=3raSno+g@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

On Sat, Jan 18, 2020 at 6:14 PM legrand legrand
<legrand_legrand(at)hotmail(dot)com> wrote:
>
> Hi Julien,
>
> bot is still unhappy
> https://travis-ci.org/postgresql-cfbot/postgresql/builds/638701399
>
> portalcmds.c: In function ‘PerformCursorOpen’:
> portalcmds.c:93:7: error: ‘queryString’ may be used uninitialized in this
> function [-Werror=maybe-uninitialized]
> plan = pg_plan_query(query, queryString, cstmt->options, params);
> ^
> portalcmds.c:50:8: note: ‘queryString’ was declared here
> char *queryString;
> ^
> cc1: all warnings being treated as errors
> <builtin>: recipe for target 'portalcmds.o' failed
> make[3]: *** [portalcmds.o] Error 1
> make[3]: Leaving directory
> '/home/travis/build/postgresql-cfbot/postgresql/src/backend/commands'
> common.mk:39: recipe for target 'commands-recursive' failed
> make[2]: *** [commands-recursive] Error 2
> make[2]: *** Waiting for unfinished jobs....

Indeed, thanks for the report! PFA rebased v4 version of the patchset.

Attachment Content-Type Size
0001-Pass-query-string-to-the-planner_v4.patch text/x-patch 10.4 KB
0002-Add-planning-counters-to-pg_stat_statements_v4.patch text/x-patch 27.8 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Kyotaro Horiguchi 2020-01-21 10:45:10 Re: Remove page-read callback from XLogReaderState.
Previous Message Dmitry Dolgov 2020-01-21 10:00:08 Re: Index Skip Scan