| From: | Julien Rouhaud <rjuju123(at)gmail(dot)com> |
|---|---|
| To: | Heikki Linnakangas <hlinnaka(at)iki(dot)fi> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Andrey Borodin <x4mmm(at)yandex-team(dot)ru>, Claudio Freire <klaussfreire(at)gmail(dot)com> |
| Subject: | Re: Sparse bit set data structure |
| Date: | 2019-03-15 06:30:10 |
| Message-ID: | CAOBaU_Ya9u-TLvm4ZSM6iYKtKRgLmdA1Uz1xJzaoD3j=13FF2Q@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Mar 14, 2019 at 4:37 PM Julien Rouhaud <rjuju123(at)gmail(dot)com> wrote:
>
> + if (newitem <= sbs->last_item)
> + elog(ERROR, "cannot insert to sparse bitset out of order");
>
> Is there any reason to disallow inserting duplicates? AFAICT nothing
> prevents that in the current code. If that's intended, that probably
> should be documented.
That of course won't work well with SBS_LEAF_BITMAP. I'd still prefer
a more explicit error message.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Kyotaro HORIGUCHI | 2019-03-15 06:33:50 | Re: Is PREPARE of ecpglib thread safe? |
| Previous Message | Imai, Yoshikazu | 2019-03-15 06:20:10 | RE: proposal: pg_restore --convert-to-text |