From: | Julien Rouhaud <rjuju123(at)gmail(dot)com> |
---|---|
To: | Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> |
Cc: | Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Add Boolean node |
Date: | 2021-12-27 10:18:45 |
Message-ID: | CAOBaU_Y0SDm_6=4=VepBsxLo1jogzWby5Jq6CJ1HxAGaW2NU-w@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Mon, Dec 27, 2021 at 5:09 PM Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> wrote:
>
> po 27. 12. 2021 v 10:02 odesílatel Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> napsal:
>>
>> This patch adds a new node type Boolean, to go alongside the "value"
>> nodes Integer, Float, String, etc. This seems appropriate given that
>> Boolean values are a fundamental part of the system and are used a lot.
>>
>> Before, SQL-level Boolean constants were represented by a string with
>> a cast, and internal Boolean values in DDL commands were usually
>> represented by Integer nodes. This takes the place of both of these
>> uses, making the intent clearer and having some amount of type safety.
>
> +1
+1 too, looks like a good improvement. The patch looks good to me,
although it's missing comment updates for at least nodeTokenType() and
nodeRead().
From | Date | Subject | |
---|---|---|---|
Next Message | Sascha Kuhl | 2021-12-27 10:24:00 | Re: Add Boolean node |
Previous Message | Pavel Stehule | 2021-12-27 10:15:00 | Re: Add Boolean node |