| From: | Anthonin Bonnefoy <anthonin(dot)bonnefoy(at)datadoghq(dot)com> |
|---|---|
| To: | Yugo Nagata <nagata(at)sraoss(dot)co(dot)jp> |
| Cc: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, Rintaro Ikeda <ikedarintarof(at)oss(dot)nttdata(dot)com>, Jakub Wartak <jakub(dot)wartak(at)enterprisedb(dot)com>, "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>, "slpmcf(at)gmail(dot)com" <slpmcf(at)gmail(dot)com>, "boekewurm+postgres(at)gmail(dot)com" <boekewurm+postgres(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, Srinath Reddy Sadipiralla <srinath2133(at)gmail(dot)com>, Dilip Kumar <dilipbalaut(at)gmail(dot)com> |
| Subject: | Re: Suggestion to add --continue-client-on-abort option to pgbench |
| Date: | 2025-09-25 08:27:44 |
| Message-ID: | CAO6_Xqq4OyDVu0BKt_kLz3nuKE-_sjCPDL7YUmSVuB4zcPt9tQ@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
The patch looks good, I've spotted some typos in the doc.
+ Allows clients to continue their run even if an SQL statement
fails due to
+ errors other than serialization or deadlock. Unlike
serialization and deadlock
+ failures, clients do not retry the same transactions but
start new transaction.
Should be "but start a new transaction.", although "proceed to the
next transaction." may be clearer here that ?
+ number of transactions that got a SQL error
+ (zero unless <option>--failures-detailed</option> is specified)
It seems like both "a SQL" and "an SQL" are used in the codebase and
doc, but this page only uses "an SQL", so using "an SQL" may be better
for consistency.
+ If an SQL command fails due to serialization or deadlock errors, the
+ client does not aborted, regardless of whether
Should be "the client does not abort."
Regards,
Anthonin Bonnefoy
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Richard Guo | 2025-09-25 08:27:57 | Re: Inconsistent Behavior of GROUP BY ROLLUP in v17 vs master |
| Previous Message | Chao Li | 2025-09-25 08:25:23 | Re: Optimize LISTEN/NOTIFY |