| From: | Anthonin Bonnefoy <anthonin(dot)bonnefoy(at)datadoghq(dot)com> |
|---|---|
| To: | Mircea Cadariu <cadariu(dot)mircea(at)gmail(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Japin Li <japinli(at)hotmail(dot)com> |
| Subject: | Re: Propagate XLogFindNextRecord error to callers |
| Date: | 2026-02-12 07:43:03 |
| Message-ID: | CAO6_XqptRqW5b3=BXZ3=OP2YL+7X_CRayCiRwpOySwuHJ2WYtw@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Feb 11, 2026 at 1:16 PM Mircea Cadariu <cadariu(dot)mircea(at)gmail(dot)com> wrote:
> Indeed. Should we place this initialisation at the top of
> XLogFindNextRecord, before any processing? At that point, there's
> nothing to erase.
That makes sense, I've added the '*errormsg = NULL' at the top of the function.
> You can consider capitalising.
Done
| Attachment | Content-Type | Size |
|---|---|---|
| v5-0001-Propagate-errormsg-to-XLogFindNextRecord-caller.patch | application/octet-stream | 8.2 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Chao Li | 2026-02-12 07:49:38 | Re: Odd usage of errmsg_internal in bufmgr.c |
| Previous Message | Aya Iwata (Fujitsu) | 2026-02-12 07:23:52 | RE: [WIP]Vertical Clustered Index (columnar store extension) - take2 |