Re: Don't use pq_putmessage in socket comm function

From: Anthonin Bonnefoy <anthonin(dot)bonnefoy(at)datadoghq(dot)com>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Don't use pq_putmessage in socket comm function
Date: 2026-07-23 08:42:34
Message-ID: CAO6_XqpOKKipC8_YqV=x1QXyVSJDALgrLw5hPSHMBipj57qc1A@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Jul 23, 2026 at 10:06 AM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
> Done this one, but only on HEAD as the existing code is not broken,
> either. That's debatable.

Thanks! I agree that this isn't an issue with the current PqCommMethods code.

I'm currently experimenting using a custom PQcommMethods layer to
compress messages, which then use PqCommSocketMethods to forward the
compressed payloads. That's how I've triggered the issue with the
socket_putmessage_noblock calling back compression's putmessage.

Without a similar setup with multiple PQcommMethods layers,
socket_putmessage_noblock using pq_putmessage shouldn't be an issue.

Regards,
Anthonin Bonnefoy

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Smith 2026-07-23 08:55:32 Re: DOCS QUESTION - space added within synopsis replaceable tag.
Previous Message Ewan Young 2026-07-23 08:35:13 Re: Fix missing FORMAT when deparsing JSON_ARRAY(query)