From: | Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com> |
---|---|
To: | Khushboo Vashi <khushboo(dot)vashi(at)enterprisedb(dot)com> |
Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
Subject: | Re: [pgAdmin4][Patch]: Psycopg3 Fixes |
Date: | 2022-10-21 03:48:34 |
Message-ID: | CANxoLDfYjCKnJ-+kuUHMPAbk+uhHpLwteQBXnCojwW=TEyL_4A@mail.gmail.com |
Views: | Whole Thread | Raw Message | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Please fix the pep8 issues as well.
On Fri, Oct 21, 2022 at 8:58 AM Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
wrote:
> Hi Khushboo
>
> I think you forgot to add the python version check in the requirements.txt
> psycopg2==2.9.*
> psycopg==3.1.0
>
> Builds are still failing.
>
> Do we have checks inside the code that if psycopg3 is installed then call
> the API of psycopg3 else fallback to psycopg2? If not then we should add
> such checks.
>
>
> On Fri, Oct 21, 2022 at 8:44 AM Akshay Joshi <
> akshay(dot)joshi(at)enterprisedb(dot)com> wrote:
>
>> Thanks, the patch applied to the psycopg3 branch
>>
>> On Thu, Oct 20, 2022 at 2:40 PM Khushboo Vashi <
>> khushboo(dot)vashi(at)enterprisedb(dot)com> wrote:
>>
>>> Hi,
>>>
>>> Please find the attached patch which includes the inclusion of psycopg2
>>> again. So, psycopg2 and psycopg3 both are supported. Also, it fixes some of
>>> the test cases which were failing. The debugger test cases fixes work is
>>> in progress.
>>>
>>> Thanks,
>>> Khushboo
>>>
>>
>>
>> --
>>
>> <http://www.enterprisedb.com>
>>
>> Akshay Joshi
>>
>> Principal Software Architect
>>
>> +91 9767888246
>>
>> www.enterprisedb.com
>>
>>
>>
>
> --
>
> <http://www.enterprisedb.com>
>
> Akshay Joshi
>
> Principal Software Architect
>
> +91 9767888246
>
> www.enterprisedb.com
>
>
>
--
Akshay Joshi
Principal Software Architect
+91 9767888246
From | Date | Subject | |
---|---|---|---|
Next Message | Pravesh Sharma | 2022-10-21 03:59:31 | [pgadmin-org/pgadmin4] 1647fc: Use SocketIO instead of REST for schema diff compa... |
Previous Message | Akshay Joshi | 2022-10-21 03:28:45 | Re: [pgAdmin4][Patch]: Psycopg3 Fixes |