Re: [pgAdmin][RM5519]: Unable to close tab after disconnecting server.

From: Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
To: Pradip Parkale <pradip(dot)parkale(at)enterprisedb(dot)com>
Cc: Dave Page <dpage(at)pgadmin(dot)org>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [pgAdmin][RM5519]: Unable to close tab after disconnecting server.
Date: 2021-04-01 06:44:56
Message-ID: CANxoLDf9OxBbMB7TQvyNtwNDn5SjyZUNYNCDkgX34DL9S4Mrmw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Thanks, patch applied.

On Thu, Apr 1, 2021 at 11:40 AM Pradip Parkale <
pradip(dot)parkale(at)enterprisedb(dot)com> wrote:

> Hi Hackers,
>
> Please find the updated patch with the change mentioned by Dave.
>
> On Wed, Mar 31, 2021 at 7:53 PM Dave Page <dpage(at)pgadmin(dot)org> wrote:
>
>> Thanks Pradip.
>>
>> Before this is committed, let's change this:
>>
>> gettext('Current trasaction is not commited because server is
>> disconnected.'),
>>
>> to:
>>
>> gettext('The current transaction has been rolled back because the server
>> was disconnected.'),
>>
>> On Wed, Mar 31, 2021 at 3:09 PM Pradip Parkale <
>> pradip(dot)parkale(at)enterprisedb(dot)com> wrote:
>>
>>> Hi Hackers,
>>> Please find the attached patch for #5519. Updated the existing
>>> confirmation message and also added a new confirmation dialog before
>>> closing the query tool if the server is disconnected.
>>>
>>> --
>>> Thanks & Regards,
>>> Pradip Parkale
>>> Software Engineer | EnterpriseDB Corporation
>>>
>>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EDB: http://www.enterprisedb.com
>>
>>
>
> --
> Thanks & Regards,
> Pradip Parkale
> Software Engineer | EnterpriseDB Corporation
>

--
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Principal Software Architect*
*EDB Postgres <http://edbpostgres.com>*

*Mobile: +91 976-788-8246*

In response to

Browse pgadmin-hackers by date

  From Date Subject
Next Message Akshay Joshi 2021-04-01 06:46:43 pgAdmin 4 commit: Fixed feature tests.
Previous Message Akshay Joshi 2021-04-01 06:44:30 pgAdmin 4 commit: Ensure that the query tool tab should be closed after