Re: [pgAdmin4[RM#3935] Grant wizard fails to list down functions

From: Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
To: Murtuza Zabuawala <murtuza(dot)zabuawala(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [pgAdmin4[RM#3935] Grant wizard fails to list down functions
Date: 2019-01-28 11:08:22
Message-ID: CANxoLDeqn8TwWfJdwQ7ZGHw_jC+hT-DncaszSMZDTkOnJ_xqLA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi Murtuza

Here are my review comments:

- Exact error should be logged in the log file and on GUI we should show
message like "Unable to fetch <function/table> object".
- Message should be shown in the status bar.
- If there is an error to fetch one kind of object, we should show other
objects.

On Mon, Jan 28, 2019 at 2:49 PM Murtuza Zabuawala <
murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:

> Hi,
>
> PFA minor patch, To display an error on UI when there is a backend error
> for the grant wizard request.
> Please review.
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
>
>
> On Mon, Jan 28, 2019 at 12:48 PM Akshay Joshi <
> akshay(dot)joshi(at)enterprisedb(dot)com> wrote:
>
>> Thanks patch applied.
>>
>> On Mon, Jan 28, 2019 at 12:01 PM Murtuza Zabuawala <
>> murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:
>>
>>> Hi,
>>>
>>> PFA patch to fix the issue where EPAS DB instance running with
>>> *no-redwood-compat* mode fails to list down functions objects in grant
>>> wizard due to 'char' -> 'int' type cast error.
>>>
>>>
>>> --
>>> Regards,
>>> Murtuza Zabuawala
>>> EnterpriseDB: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>>
>>
>> --
>> *Akshay Joshi*
>>
>> *Sr. Software Architect *
>>
>>
>>
>> *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
>>
>

--
*Akshay Joshi*

*Sr. Software Architect *

*Phone: +91 20-3058-9517Mobile: +91 976-788-8246*

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Dave Page 2019-01-28 11:31:19 Re: [pgAdmin4][RM3936] Feature tests failing intermittently for SQL editor related test cases
Previous Message Murtuza Zabuawala 2019-01-28 09:19:00 Re: [pgAdmin4[RM#3935] Grant wizard fails to list down functions