From: | Michail Nikolaev <michail(dot)nikolaev(at)gmail(dot)com> |
---|---|
To: | PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, nathan(at)postgresql(dot)org, Michael Paquier <michael(at)paquier(dot)xyz>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi> |
Subject: | Re: Strange assertion in procarray.c |
Date: | 2024-11-28 20:04:36 |
Message-ID: | CANtu0oiBAcVnzYYETbWY+2gFXUeAx8BKArjnFco4LeAHfH38Sw@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Hello, Heikki, Nathan and Michael!
Oh, please excuse my impudence in bringing you all here, but I finally
found what almost the same issue was fixed by Heikki already [0].
I discovered that a similar issue was previously addressed by Heikki in
commit [0], where installcheck was disabled for injection point tests.
However, in the meson build configuration, this was only applied to
regression tests - the isolation and TAP tests are still running during
installcheck.
As demonstrated in the previously shared reproducer [1], even *local*
injection points can cause backend crashes through unexpected side effects.
Therefore, I propose extending the installcheck disable to cover both TAP
and isolation tests as well.
I've attached a patch implementing these changes.
A patch with such change is attached.
Best regards,
Mikhail.
[0]:
https://github.com/postgres/postgres/commit/e2e3b8ae9ed73fcd3096c5ca93971891a7767388
[1]:
https://www.postgresql.org/message-id/flat/CANtu0ojbx6%3DesP8euQgzD1CN6tigTQvDmupwEmLTHZT%3D6_yx_A%40mail.gmail.com#18544d553544da67b4fc1ef764df3c3d
>
Attachment | Content-Type | Size |
---|---|---|
v2-0001-Test-to-reproduce-issue-with-crash-caused-by-pass.patch | text/plain | 4.3 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Michael Banck | 2024-11-28 20:17:23 | Re: [PATCH] Add support for displaying database service in psql prompt |
Previous Message | Peter Eisentraut | 2024-11-28 19:46:46 | Re: UUID v7 |