| From: | Jeevan Ladhe <jeevanladhe(dot)os(at)gmail(dot)com> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, "Shinoda, Noriyoshi (PN Japan FSIP)" <noriyoshi(dot)shinoda(at)hpe(dot)com>, Justin Pryzby <pryzby(at)telsasoft(dot)com>, Dipesh Pandit <dipesh(dot)pandit(at)gmail(dot)com>, Abhijit Menon-Sen <ams(at)toroid(dot)org>, Dmitry Dolgov <9erthalion6(at)gmail(dot)com>, Jeevan Ladhe <jeevan(dot)ladhe(at)enterprisedb(dot)com>, Mark Dilger <mark(dot)dilger(at)enterprisedb(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, tushar <tushar(dot)ahuja(at)enterprisedb(dot)com>, Andres Freund <andres(at)anarazel(dot)de> |
| Subject: | Re: refactoring basebackup.c |
| Date: | 2022-03-08 16:58:34 |
| Message-ID: | CANm22CiVwmix7JGOGhJYsbNt9M8AH-svG2HQfPP=MdZ2kMHfzw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
ok got it. Thanks for your insights.
Regards,
Jeevan Ladhe
On Tue, 8 Mar 2022 at 22:23, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> On Tue, Mar 8, 2022 at 11:32 AM Jeevan Ladhe <jeevanladhe(dot)os(at)gmail(dot)com>
> wrote:
> > I reviewed the patch, and it seems to be capturing and replacing all the
> > places of HAVE_LIB* with USE_* correctly.
> > Just curious, apart from consistency, do you see other problems as well
> > when testing one vs the other?
>
> So, the kind of problem you would worry about in a case like this is:
> suppose that configure detects LIBLZ4, but the user specifies
> --without-lz4. Then maybe there is some way for HAVE_LIBLZ4 to be
> true, while USE_LIBLZ4 is false, and therefore we should not be
> compiling code that uses LZ4 but do anyway. As configure.ac is
> currently coded, I think that's impossible, because we only search for
> liblz4 if the user says --with-lz4, and if they do that, then USE_LZ4
> will be set. Therefore, I don't think there is a live problem here,
> just an inconsistency.
>
> Probably still best to clean it up before an angry Andres chases me
> down, since I know he's working on the build system...
>
> --
> Robert Haas
> EDB: http://www.enterprisedb.com
>
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Christoph Heiss | 2022-03-08 17:17:36 | Re: [PATCH] Add reloption for views to enable RLS |
| Previous Message | Robert Haas | 2022-03-08 16:53:19 | Re: refactoring basebackup.c |