| From: | Shlok Kyal <shlok(dot)kyal(dot)oss(at)gmail(dot)com> |
|---|---|
| To: | Nisha Moond <nisha(dot)moond412(at)gmail(dot)com> |
| Cc: | shveta malik <shveta(dot)malik(at)gmail(dot)com>, Peter Smith <smithpb2250(at)gmail(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Zsolt Parragi <zsolt(dot)parragi(at)percona(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Support EXCEPT for TABLES IN SCHEMA publications |
| Date: | 2026-07-31 07:47:48 |
| Message-ID: | CANhcyEXtX-tAMMMvsK+e1TUzUWT77+iwTbXPx-nM1Va_UjYTHg@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> Attached v24 patch set.
>
Hi Nisha,
While addressing comments for one of my patches, I took a quick look
at patch 0004 (the documentation patch). I have a few comments:
1. While building documenttation, I find following error:
/usr/bin/xmllint --nonet --path . --path . --output postgres-full.xml
--noent --valid postgres.sgml
/usr/bin/xsltproc --nonet --path . --path . --stringparam pg.version
'20devel' stylesheet.xsl postgres-full.xml
ERROR: id attribute missing on <varlistentry> element under /book[(at)id
= 'postgres']/part[(at)id = 'reference']/reference[(at)id =
'sql-commands']/refentry[(at)id =
'sql-alterpublication']/refsect1/variablelist
no result for postgres-full.xml
make: *** [Makefile:130: html-stamp] Error 10
I think we need to define a id attribute here:
+ <varlistentry>
+ <term><literal>EXCEPT</literal></term>
+ <listitem>
2. Should we add 'clause' after <literal>EXCEPT</literal> ?
+ SCHEMA</literal>, the exclusion applies only to tables in the schema
+ associated with the <literal>EXCEPT</literal>.
3. Maybe we can simplify the below:
+ <structname>sales.drafts</structname>. Other than
+ <structname>sales.drafts</structname>, any previously excluded
tables for schema
+ <structname>sales</structname> are no longer excluded. Any schemas
previously in
Maybe change:
Other than <structname>sales.drafts</structname>, any previously excluded tables
for schema <structname>sales</structname> are no longer excluded.
to:
All other previously excluded tables in schema <structname>sales</structname>
are no longer excluded.
Thanks,
Shlok Kyal
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2026-07-31 07:55:19 | Re: DOCS QUESTION - space added within synopsis replaceable tag. |
| Previous Message | Michael Paquier | 2026-07-31 07:35:19 | Re: Increase repalloc_array() usage in buffile.c |