| From: | Shlok Kyal <shlok(dot)kyal(dot)oss(at)gmail(dot)com> |
|---|---|
| To: | shveta malik <shveta(dot)malik(at)gmail(dot)com> |
| Cc: | Peter Smith <smithpb2250(at)gmail(dot)com>, Ashutosh Sharma <ashu(dot)coek88(at)gmail(dot)com>, vignesh C <vignesh21(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Support EXCEPT for ALL SEQUENCES publications |
| Date: | 2026-09-16 10:42:37 |
| Message-ID: | CANhcyEWb-iB0w3J4fQWbFrNevjeW_s3G=i6KHCTiRVdJnS0dKw@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, 6 Aug 2026 at 17:24, shveta malik <shveta(dot)malik(at)gmail(dot)com> wrote:
>
> On Tue, Aug 4, 2026 at 1:10 PM Shlok Kyal <shlok(dot)kyal(dot)oss(at)gmail(dot)com> wrote:
> >
> >
> > I have addressed the above comments and attached the updated v24 patch.
> >
>
> Thanks Shlok. I don't have further comments on the patches.
>
> A trivial suggestion (no need to send a new version for this, do it if
> you get further comments though).
>
> create_publication.sgml:
>
> Temporary
> sequences and unlogged sequences are excluded from the publication.
> + Sequences listed in the <literal>EXCEPT</literal> clause are
> excluded from
> + the publication.
>
> Should we tweak it to the below to avoid repeated "excluded from the
> publication"
>
> Temporary sequences, unlogged sequences, and sequences listed in the
> EXCEPT clause are excluded from the publication.
>
The patches required a rebase.
Attached the rebased patch and also addressed the comment by Shveta.
Thanks,
Shlok Kyal
| Attachment | Content-Type | Size |
|---|---|---|
| v25-0002-Support-EXCEPT-for-ALL-SEQUENCES-in-ALTER-PUBLIC.patch | application/octet-stream | 35.8 KB |
| v25-0001-Support-EXCEPT-for-ALL-SEQUENCES-in-CREATE-PUBLI.patch | application/octet-stream | 70.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alexander Korotkov | 2026-09-16 10:51:43 | Re: Two issues leading to discrepancies in FSM data on the standby server |
| Previous Message | Amit Kapila | 2026-09-16 10:31:21 | Re: [PATCH] Release replication slot on error in SQL-callable slot functions |