From: | Shlok Kyal <shlok(dot)kyal(dot)oss(at)gmail(dot)com> |
---|---|
To: | shveta malik <shveta(dot)malik(at)gmail(dot)com> |
Cc: | Peter Smith <smithpb2250(at)gmail(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, "Zhijie Hou (Fujitsu)" <houzj(dot)fnst(at)fujitsu(dot)com>, vignesh C <vignesh21(at)gmail(dot)com>, YeXiu <1518981153(at)qq(dot)com>, Ian Lawrence Barwick <barwick(at)gmail(dot)com>, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: Skipping schema changes in publication |
Date: | 2025-08-03 16:12:16 |
Message-ID: | CANhcyEWDB9ALsbMJ3RsrXs78TSdHoeUGpm2oKr8EdhwCtEYXXQ@mail.gmail.com |
Views: | Whole Thread | Raw Message | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Wed, 23 Jul 2025 at 10:08, shveta malik <shveta(dot)malik(at)gmail(dot)com> wrote:
>
> I further tested inherited tables flow as well wrt ONLY and EXCEPT, it
> works well. But while reading docs for the saem, I have few concerns.
>
> 1)
> While explaining ONLY for EXCEPT, create-publication doc says this
>
> + This does not apply to a partitioned table, however. The partitions of
> + a partitioned table are always implicitly considered part of the
> + publication, so they are never explicitly excluded from the publication.
>
> I do not understand the last line: "so they are never explicitly
> excluded from the publication" . But we can explicitly exclude them
> using EXCEPT <partition_name>. Do you mean to say something else here?
>
> 2)
> alter-publication doc says (in context of EXCEPT):
>
> "If ONLY is specified before the table name, only that table is
> affected. If ONLY is not specified, the table and all its descendant
> tables (if any) are affected. Optionally, * can be specified after
> the table name to explicitly indicate that descendant tables are
> affected."
>
> But it does not mention anything for partitions. I think we shall
> mention here as well that this does not apply to a partitioned table.
> (I tested ONLY and EXCEPT for partition-root. UNLIKE inherited tables,
> ONLY has no impact on partitioned tables.)
>
> 3)
> Shall we explain the relation of 'publish_via_partition_root' with
> EXCEPT briefly in docs(once we conclude that design)?
>
> Please note that I have performed all the tests (mentioned here and in
> previous emails) on patch001 and patch002. patch003 is not applied in
> these tests.
>
I have added/ modified the documentations as per the comments. The
changes are present in patch [1].
[1]: https://www.postgresql.org/message-id/CANhcyEXkeg3sjkS3DS9yU1ckz4ozUBNZ%2BRmrWaRNSSVCR8RquA%40mail.gmail.com
Thanks,
Shlok Kyal
From | Date | Subject | |
---|---|---|---|
Next Message | Paul A Jungwirth | 2025-08-03 19:32:31 | Re: Inval reliability, especially for inplace updates |
Previous Message | Shlok Kyal | 2025-08-03 16:11:24 | Re: Skipping schema changes in publication |