Re: Support EXCEPT for ALL SEQUENCES publications

On Mon, 6 Jul 2026 at 11:34, Ashutosh Sharma <ashu(dot)coek88(at)gmail(dot)com> wrote:
>
> Thanks for fixing this. I found a few cosmetics issues while reviewing
> the latest patches, please see if these make sense to you:
>
> +# Check ALTER PUBLICATION ... ALL SEQUENCES (EXCEPT SEQUENCE ...)
> +$node_publisher->safe_psql(
>
> The placement of the EXCEPT clause here doesn't match the actual
> supported syntax. The correct form is:
>
> CREATE PUBLICATION combined_pub_seq FOR ALL SEQUENCES EXCEPT ( SEQUENCE ... )
>
> --
>
> + * Get the list of tables and sequences for publications specified in
> + * the EXCEPT clause.
>
> Above comment doesn't look clearer to me. Perhaps something like "for
> tables and sequences specified in the publication's EXCEPT clause"
> would read more clearly. What do you think?
>
> --
>
> + /* Print publications where the sequence is in the EXCEPT clause */
> + if (pset.sversion >= 200000)
>
> This doesn't read well as well, how about "Print publications whose
> EXCEPT clause contains this sequence"?
>
> --
>
> + * In FOR ALL TABLES/ FOR ALL SEQUENCES mode, relations are
>
> This seems to be having uneven spacing. I would rather replace '/'
> with 'or' here.
>
Hi Ashutosh,

Thanks for reviewing the patch.
I agree with your comments and addressed it in the lastest v19 patch.

I also noticed that the CI runs are failing.
It is failing because of the new test added in 0002 patch.
After we alter the publication and change the sequences in the EXCEPT
list, we should run 'ALTER SUBSCRIPTION ... REFRESH PUBLICATION' on
the subscription, so the same is reflected on the pg_subscription_rel.
I have made the change for the same in the updated patch.

Thanks
Shlok Kyal