From: | Simon Riggs <simon(dot)riggs(at)enterprisedb(dot)com> |
---|---|
To: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Zheng Li <zhengli10(at)gmail(dot)com>, Jim Nasby <nasbyj(at)amazon(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Reducing power consumption on idle servers |
Date: | 2022-11-13 23:07:34 |
Message-ID: | CANbhV-GcWjZ2cmj0uCbZDWQUHnneMi_4EfY3dVWq0-yD5o7Ccg@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Sun, 13 Nov 2022 at 21:28, Thomas Munro <thomas(dot)munro(at)gmail(dot)com> wrote:
>
> On Mon, Nov 14, 2022 at 5:52 AM Simon Riggs
> <simon(dot)riggs(at)enterprisedb(dot)com> wrote:
> > The attached patch is a reduced version of the original. It covers only:
> > * deprecation of the promote_trigger_file - there are no tests that
> > use that, hence why there is no test coverage for the patch
> > * changing the sleep time of the startup process to 60s
> > * docs and comments
>
> LPGTM. If we also fix the bogus SIGALRM wakeups[1], then finally a
> completely idle recovery process looks like:
>
> kevent(8,0x0,0,{ },1,{ 60.000000000 }) = 0 (0x0)
> kevent(8,0x0,0,{ },1,{ 60.000000000 }) = 0 (0x0)
> kevent(8,0x0,0,{ },1,{ 60.000000000 }) = 0 (0x0)
>
> Presumably it would have no timeout at all in the next release.
>
> [1] https://www.postgresql.org/message-id/CALj2ACUiYn+ZmPGUVmGeoY1u7ino2qsvqrnufk8sWPvK3A8yJA@mail.gmail.com
Clearly, I haven't been watching Hackers! Thanks for the nudge.
See if this does the trick?
--
Simon Riggs http://www.EnterpriseDB.com/
Attachment | Content-Type | Size |
---|---|---|
hibernate_startup.v7.patch | application/octet-stream | 7.1 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Thomas Munro | 2022-11-13 23:11:19 | Re: Suppressing useless wakeups in walreceiver |
Previous Message | Nathan Bossart | 2022-11-13 22:26:44 | Re: Suppressing useless wakeups in walreceiver |