Re: Reducing power consumption on idle servers

From: Thomas Munro <thomas(dot)munro(at)gmail(dot)com>
To: Simon Riggs <simon(dot)riggs(at)enterprisedb(dot)com>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Zheng Li <zhengli10(at)gmail(dot)com>, Jim Nasby <nasbyj(at)amazon(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Reducing power consumption on idle servers
Date: 2022-11-13 21:28:14
Message-ID: CA+hUKG+HKzCTa=Wotud0yLq52qj3D9qFMQrPM5bM-WVkNNioPw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Nov 14, 2022 at 5:52 AM Simon Riggs
<simon(dot)riggs(at)enterprisedb(dot)com> wrote:
> The attached patch is a reduced version of the original. It covers only:
> * deprecation of the promote_trigger_file - there are no tests that
> use that, hence why there is no test coverage for the patch
> * changing the sleep time of the startup process to 60s
> * docs and comments

LPGTM. If we also fix the bogus SIGALRM wakeups[1], then finally a
completely idle recovery process looks like:

kevent(8,0x0,0,{ },1,{ 60.000000000 }) = 0 (0x0)
kevent(8,0x0,0,{ },1,{ 60.000000000 }) = 0 (0x0)
kevent(8,0x0,0,{ },1,{ 60.000000000 }) = 0 (0x0)

Presumably it would have no timeout at all in the next release.

[1] https://www.postgresql.org/message-id/CALj2ACUiYn+ZmPGUVmGeoY1u7ino2qsvqrnufk8sWPvK3A8yJA@mail.gmail.com

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2022-11-13 22:08:04 Re: Suppressing useless wakeups in walreceiver
Previous Message Tomas Vondra 2022-11-13 21:15:51 Re: WIP: Aggregation push-down - take2