| From: | Simon Riggs <simon(dot)riggs(at)enterprisedb(dot)com> |
|---|---|
| To: | Matthias van de Meent <boekewurm+postgres(at)gmail(dot)com> |
| Cc: | Peter Geoghegan <pg(at)bowt(dot)ie>, John Naylor <john(dot)naylor(at)enterprisedb(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Mark Dilger <mark(dot)dilger(at)enterprisedb(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Lowering the ever-growing heap->pd_lower |
| Date: | 2021-08-03 18:37:13 |
| Message-ID: | CANbhV-Eb3r45YacuBJd_Tbt+VkLAEC6mOY12crWgzLPjh6=FjQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, 3 Aug 2021 at 17:15, Matthias van de Meent
<boekewurm+postgres(at)gmail(dot)com> wrote:
> and further future optimizations might include
>
> - Full-page WAL logging of empty pages produced in the checkpointer
> could potentially be optimized to only log 'it's an empty page'
> instead of writing out the full 8kb page, which would help in reducing
> WAL volume. Previously this optimization would never be hit on
> heapam-pages because pages could not become empty again, but right now
> this has real potential for applying an optimization.
So what you are saying is your small change will cause multiple
additional FPIs in WAL. I don't call that a future optimization, I
call that essential additional work.
+1 on committing the first part of the patch, -1 on the second. I
suggest you split the patch and investigate the second part further.
--
Simon Riggs http://www.EnterpriseDB.com/
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tomas Vondra | 2021-08-03 18:51:57 | Re: Commitfest overflow |
| Previous Message | Ibrar Ahmed | 2021-08-03 18:34:01 | Re: Commitfest overflow |