From: | John Naylor <johncnaylorls(at)gmail(dot)com> |
---|---|
To: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: generate syscache info automatically |
Date: | 2024-01-19 05:28:28 |
Message-ID: | CANWCAZbvK_OVAfZPXxK8tey53CTnmwuxgJAbFEBWt57rAUN0Ag@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Wed, Jan 17, 2024 at 7:46 PM Peter Eisentraut <peter(at)eisentraut(dot)org> wrote:
>
> I updated the patch to use this style (but I swapped the first two
> arguments from my example, so that the thing being created is named first).
>
> I also changed the names of the output files a bit to make them less
> confusing. (I initially had some files named .c.h, which was weird, but
> apparently necessary to avoid confusing the build system. But it's all
> clearer now.)
>
> Other than bugs and perhaps style opinions, I think the first patch is
> pretty good now.
LGTM. The only style consideration that occurred to me just now was
MAKE_SYSCACHE, since it doesn't match the DECLARE_... macros. It seems
like the same thing from a code generation perspective. The other
macros refer to relations, so there is a difference, but maybe it
doesn't matter. I don't have a strong opinion.
From | Date | Subject | |
---|---|---|---|
Next Message | Amit Kapila | 2024-01-19 05:52:51 | Re: Synchronizing slots from primary to standby |
Previous Message | Michael Paquier | 2024-01-19 05:26:54 | Re: "ERROR: could not open relation with OID 16391" error was encountered when reindexing |