| From: | John Naylor <johncnaylorls(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Andres Freund <andres(at)anarazel(dot)de>, Peter Eisentraut <peter(at)eisentraut(dot)org> |
| Subject: | cpluspluscheck vs ICU again |
| Date: | 2025-07-02 07:01:13 |
| Message-ID: | CANWCAZbgiaz1_0-F4SD+=-e9onwAnQdBGJbhg94EqUu4Gb7WyA@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Jul 1, 2025 at 9:24 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Ha, indeed you are right. On my RHEL9 box, it's kinda drowned out
> by complaints about
>
> /usr/include/c++/11/bits/range_access.h:109:3: error: template with C linkage
> 109 | template<typename _Tp> _Tp* end(valarray<_Tp>&) noexcept;
> | ^~~~~~~~
> /tmp/headerscheck.u5CrRM/test.cpp:1:1: note: ‘extern "C"’ linkage started here
> 1 | extern "C" {
> | ^~~~~~~~~~
After pushing my fix, I looked into this, and CI works around this by
disabling ICU. A proper fix was discussed here, but it trailed off:
I came up with the attached -- Andres, Peter, does this match your recollection?
--
John Naylor
Amazon Web Services
| Attachment | Content-Type | Size |
|---|---|---|
| v1-0001-Properly-fix-cpluspluscheck-with-ICU.patch | text/x-patch | 1.6 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andy Fan | 2025-07-02 07:02:52 | parallel safety of correlated subquery (was: parallel_safe) |
| Previous Message | Dean Rasheed | 2025-07-02 06:48:31 | Re: Allow the "operand" input of width_bucket() to be NaN |