| From: | John Naylor <johncnaylorls(at)gmail(dot)com> |
|---|---|
| To: | Zsolt Parragi <zsolt(dot)parragi(at)percona(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, root <tenistarkim(at)gmail(dot)com>, Nathan Bossart <nathandbossart(at)gmail(dot)com> |
| Subject: | Re: centralize CPU feature detection |
| Date: | 2026-02-27 13:38:36 |
| Message-ID: | CANWCAZbAPFT0w-gZGS4dfJ4HPk7tRAed6vUS67TdEJ1-DoqCHg@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Feb 25, 2026 at 8:09 PM Zsolt Parragi <zsolt(dot)parragi(at)percona(dot)com> wrote:
>
> Both look good to me.
Pushed 0002 after making sure AVX-512 detection still worked, thanks
for the review! I think 0003 needs a link to the Intel manual for the
XCR symbol values, and I'll push shortly after I add that.
> This isn't part of the patch, and it seems harmless, but while
> reviewing the CRC functions, I noticed that pg_crc32c.h is
> inconsistent with its dllimport markers, pg_comp_crc32c has 3
> different declarations, and only 1 of them is marked PGDLLIMPORT.
Yeah, I think that crept in during development to keep Windows CI
building with a not-for-commit test module. I'll remove it soon.
--
John Naylor
Amazon Web Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Daniil Davydov | 2026-02-27 13:49:15 | Re: POC: Parallel processing of indexes in autovacuum |
| Previous Message | Andrey Borodin | 2026-02-27 13:03:06 | Re: pageinspect support for SpGiST |