| From: | John Naylor <johncnaylorls(at)gmail(dot)com> |
|---|---|
| To: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Nathan Bossart <nathandbossart(at)gmail(dot)com>, Matthias van de Meent <boekewurm+postgres(at)gmail(dot)com>, Yura Sokolov <y(dot)sokolov(at)postgrespro(dot)ru> |
| Subject: | Re: [PoC] Improve dead tuple storage for lazy vacuum |
| Date: | 2024-03-06 09:10:35 |
| Message-ID: | CANWCAZb9nov4AANWSrwHyQ2rss9b9SqxZ5zhaS3YtET8D4HAiQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Mar 6, 2024 at 3:40 PM Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> wrote:
>
> On Wed, Mar 6, 2024 at 5:33 PM John Naylor <johncnaylorls(at)gmail(dot)com> wrote:
> > I've looked around and it seems clang is more lax on conversions.
> > Since it works fine for clang, I think we just need a cast here for
> > gcc. I've attached a blind attempt at a fix -- I'll apply shortly
> > unless someone happens to test and find it doesn't work.
>
> I've reproduced the same error on my raspberry pi, and confirmed the
> patch fixes the error.
>
> My previous idea was wrong. With my proposal, the regression test for
> radix tree failed on my raspberry pi. On the other hand, with your
> patch the tests passed.
Pushed, and at least parula's green now, thanks for testing! And
thanks, Andres, for the ping!
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bertrand Drouvot | 2024-03-06 09:12:15 | Re: Introduce XID age and inactive timeout based replication slot invalidation |
| Previous Message | Peter Eisentraut | 2024-03-06 09:07:27 | Re: pipe_read_line for reading arbitrary strings |