Re: cpluspluscheck vs ICU again

From: John Naylor <johncnaylorls(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Andres Freund <andres(at)anarazel(dot)de>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Peter Eisentraut <peter(at)eisentraut(dot)org>
Subject: Re: cpluspluscheck vs ICU again
Date: 2025-07-09 07:40:40
Message-ID: CANWCAZarC0JRpzdsq-m8D5PnhpThPpvYBK=FhpXfd6+OK=KpYQ@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Jul 7, 2025 at 11:06 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>
> John Naylor <johncnaylorls(at)gmail(dot)com> writes:
> > I see that now. If extensions follow the practice of including system
> > headers before Postgres headers, it should be fine. I've attached v2
> > which removes the useless #undef and drafts an explanatory commit
> > message.
>
> Works for me.

Pushed.

--
John Naylor
Amazon Web Services

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Yura Sokolov 2025-07-09 07:56:34 Re: Optimize shared LWLock acquisition for high-core-count systems
Previous Message Bertrand Drouvot 2025-07-09 07:37:11 Re: Add os_page_num to pg_buffercache