Re: [PATCH] Use ssup_datum_*_cmp for int2, oid, and oid8 sort support

On Thu, Aug 6, 2026 at 3:29 PM David Rowley <dgrowleyml(at)gmail(dot)com> wrote:
> > On Fri, Jul 24, 2026 at 7:04 PM Zsolt Parragi <zsolt(dot)parragi(at)percona(dot)com> wrote:

> > + /*
> > + * We cannot use ssup_datum_unsigned_cmp here, since the upper half of a
> > + * Datum containing a 32-bit type is not reliably zero-extended.
> > + */
> >
> > ...by mentioning 32-bit the difference from oid8 should be obvious, I hope.
>
> Is it ever necessary to have that as a comment? Maybe it'd be better
> to rename ssup_datum_unsigned_cmp to ssup_datum_uint64_cmp. It just
> doesn't seem questionable why you'd use the 64-bit version for a
> 32-bit type with those names.

Yeah, self-documenting code is best. I'll plan on pushing both the
rename and v2 early next week. Thanks for looking!

--
John Naylor
Amazon Web Services