Re: Hide exposed impl detail of wchar.c

From: John Naylor <johncnaylorls(at)gmail(dot)com>
To: Nathan Bossart <nathandbossart(at)gmail(dot)com>
Cc: Jubilee Young <workingjubilee(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Hide exposed impl detail of wchar.c
Date: 2023-11-17 10:26:20
Message-ID: CANWCAZacvS0UyhbZ9jGp6MM=59dVyRATujmqCm_EGCjSkGd60w@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Nov 17, 2023 at 5:54 AM Nathan Bossart <nathandbossart(at)gmail(dot)com> wrote:
>
> It looks like is_valid_ascii() was originally added to pg_wchar.h so that
> it could easily be used elsewhere [0] [1], but that doesn't seem to have
> happened yet.
>
> Would moving this definition to a separate header file be a viable option?

Seems fine to me. (I believe the original motivation for making it an
inline function was for in pg_mbstrlen_with_len(), but trying that
hasn't been a priority.)

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Heikki Linnakangas 2023-11-17 10:37:21 Re: Relation bulk write facility
Previous Message Alvaro Herrera 2023-11-17 10:01:21 Re: trying again to get incremental backup