Re: Move system identifier generation to a common helper

On Thu, Jun 4, 2026 at 7:22 PM Imran Zaheer <imran(dot)zhir(at)gmail(dot)com> wrote:
> The code used to generate a new system identifier is duplicated in
> multiple locations, including BootStrapXLOG(), pg_createsubscriber, and
> pg_resetwal.
>
> Move the generation logic into a common GenerateSystemIdentifier()
> helper so that all callers use a single implementation, avoiding
> duplication of the same algorithm.

This seems like a useful cleanup, and the first step to take if we end
up using any of the ideas in this thread at some point.

I'm not really a fan of creating a new C file and new header for just
one function. Maybe there's an existing logical place for it?

--
John Naylor
Amazon Web Services